Stamp verdict flips and failure reasons on health-check telemetry - #1835
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 4ed2784 | Aug 29 2026, 06:50 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 4ed2784 | Commit Preview URL Branch Preview URL |
Aug 29 2026, 06:50 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The health span (
executor.connection.health.check) records the verdict but not what it replaced, so flapping — a connection oscillating between healthy and degraded — is only visible by diffing consecutive spans per connection. It also collapses very different failures (a probe timeout, a refused token refresh, a failed tool sync) into onedegradedlabel, with the cause only in free text that never reaches telemetry.executor.health.previous_statusandexecutor.health.changedto the health span: the verdict this check replaced, read from the row before probing. A first-ever verdict stamps neither.reasontoHealthCheckResult(credential_missing,credential_refresh_rejected,probe_timeout,probe_failed,upstream_status,tool_sync_failed), populated at every non-healthy verdict production site (core credential fold, dead-grant verdict, tool-sync stamp, MCP / OpenAPI / GraphQL probes) and stamped asexecutor.health.reason. Free-textdetailstill never goes on a span.timedOutmarker onMcpToolDiscoveryErrorso a slow-but-alive server classifies asprobe_timeoutwithout string-matching the message.